Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove column_axis from StencilInfo and generate_gtheader #418

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Mar 19, 2024

remove column_axis from StencilInfo.
column_axis is hardcoded to KDim in translation.generate_stencil_source for ScanOperators

@halungge halungge requested a review from samkellerhals March 19, 2024 13:47
@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

launch jenkins spack

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor Author

cscs-ci run dace

@edopao
Copy link
Contributor

edopao commented Mar 20, 2024

The failure in dace test is a different issue. I will provide a fix today.

@halungge halungge merged commit 43d6820 into main Mar 20, 2024
5 of 6 checks passed
iomaganaris referenced this pull request in iomaganaris/icon4py Jun 18, 2024
* remove column_axis from StencilInfo and generate_gtheader

* fix test_backend.py

* set column_axis=KDim for scan
@halungge halungge deleted the fix_column_axis branch December 12, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants